Shadowfury
previous_open_issue.png
Go to the previous open issue
previous_issue.png
Go to the previous issue (open or closed)
star_faded.png
Please log in to bookmark issues
bug_report_small.png
Open Bug report FBCal-109 Leap birthdays (Feb 29) not handled correctly in calendar
next_issue.png
Go to the next issue (open or closed)
next_open_issue.png
Go to the next open issue
Description

When a friend has a birthday on Feb 29th, it is not correctly populated in the calendar. On leap years (such as 2016), the birthday will be shown on March 1st rather than Feb 29th.

Steps to reproduce this issue
Nothing entered.
Comments (2)
#1
user-offline.png  Shadowfury (administrator)
Feb 28, 2016 - 12:53

This is going to be fairly tricky to solve. On leap-years, the birthday will be correctly reported by Facebook and that should be fairly easy to write an exception case for. On non-leap-years, the birthday will not be reported correctly by Facebook because it will be automatically corrected to a date that actually exists. So, adjusting the birthday back to the correct Feb 29th date on non-leap-years is likely to be pretty much impossible with the amount of data available.

#2
user-offline.png  Shadowfury (administrator)
Mar 05, 2016 - 11:30
I think the best bet here will be to do the following:

- Delete all birthdays over 1 year old
- Do nothing for birthdays that are past but are younger than 1 year old
- Overwrite birthdays in the future

This should allow for both the most recent previous birthday and the closest upcoming birthday to be displayed correctly each year. Unfortunately, this does not address leap birthdays in years beyond the closest upcoming, which will still display on March 1st rather than Feb 29th. Although, that will only affect users looking more than 1 year into the future for birthdays.
Changes:
  •   icon_milestone.pngMilestone changed: Unscheduled => 0.11
History
Issue basics
  • Type of issue
    Bug report
  • Category
    Not determined
  • Targetted for
    1.0
  • Status
    New
  • Progress
  • Priority
    Not determined
User pain
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
Affected by this issue (0)
There are no items
People involved
Times and dates
  • Posted at
  • Last updated
  • Estimated time
    Not estimated
  • Time spent
    No time spent
    Click here to see time logged against this issue
Issue details
  • Resolution
    Not determined
  • Reproducability
    Not determined
  • Severity
    Not determined
Attachments (0)
There is nothing attached to this issue
Duplicate issues (0)
This issue does not have any duplicates